Replace undocumented APIs with documented APIs in the OpenJDK #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also create an issue in the wepoll repo so that this issue can also be addressed at the source? |
Thanks @swesonga, The repository appears to be inactive, and no updates have been made since 11/30/2020. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wepollcode has been ported from opensource repowepollto OpenJDK in PR pull/3816, which incorporated undocumented Windows APIs (NtCreateKeyedEvent, NtReleaseKeyedEvent, NtWaitForKeyedEvent).This PR aims to replace these undocumented APIs with documented synchronization APIs.
Test Performed:
All 12 tests in wepoll repo passed
test-auto-drop-on-close PASS
test-connect-fail-events PASS
test-connect-success-events PASS
test-ctl-fuzz PASS
test-error PASS
test-leak-1 PASS
test-mixed-socket-types PASS
test-multi-poll PASS
test-oneshot-and-hangup PASS
test-reflock PASS
test-tree PASS
test-udp-pings PASS
DONE - 12 PASSED, 0 FAILED
No new failure in JTreg test
Micro bench results: similar performance score before and after the changes
without change in this PR:
With the change in this PR: